Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus pane based on click location when foregrounding #739

Open
ianterrell opened this issue Feb 8, 2022 · 20 comments
Open

Focus pane based on click location when foregrounding #739

ianterrell opened this issue Feb 8, 2022 · 20 comments

Comments

@ianterrell
Copy link

ianterrell commented Feb 8, 2022

Describe the solution you'd like?

It would be nice if Warp focused on the pane clicked on when coming back from the background. Currently I have to click twice to select the pane I want to use.

I use a multilane workflow and this catches me quite a lot; I find myself typing into the wrong pane.

See comparison with iTerm2, even with focus follows mouse disabled:

Screen.Recording.2022-02-08.at.2.47.46.PM.mov

Combined with other issues, it makes me wonder if I'm in a minority using multiple panes in my terminal.

@elviskahoro
Copy link

Fixed in latest release

@fwouts
Copy link

fwouts commented Apr 8, 2022

I'm still seeing this bug in v0.2022.04.01.01.37.stable_03 on MacOS 12.3.

@elviskahoro was it included in that release?

@elviskahoro elviskahoro reopened this Apr 12, 2022
@elviskahoro
Copy link

I think we had to revert it. Thanks for commenting!

@elviskahoro
Copy link

Often I click just to make sure the window is focused and I don't want to highlight/select anything.

@lobocv
Copy link

lobocv commented Apr 21, 2022

Would really love to see this feature. It drives me nuts when I change from my IDE to the terminal and start typing a command only to realize I need to click it again! It would be great if when you click on warp the first time, it will go to the cursor of the pane you clicked on. I think right now it focuses on the last output command and doesn't show the cursor prompt until I click again right near the text input

@dev4joel
Copy link

From swolf via Discord

Current flow: I use a split left/right pane layout for both my workflows. I frequently switch between panes. When I do so from the window being in an inactive state two clicks are required. The first sets the window active, and the second is required to switch panes
Desired flow: Use the click that sets the window active to also change pane if the click lands on an inactive pane.

It's minor, but I still find myself expecting to only need one click. I'd love if this could be changed

@jsharpe
Copy link

jsharpe commented Aug 16, 2022

@elviskahoro given you had a fix for this can't this be reapplied in the latest versions? The original fix was made in March, its now August which suggests that this has fallen off your priority list?

@elviskahoro
Copy link

Good point. The original feature ended up causing another bug and so we removed it. After looking into the bug, we realized it be a much bigger engineering lift than anticipated. I'll reach back out and see.

@elviskahoro
Copy link

It's too big of an engineering lift at the moment. An so it's been deprioritized.

@korygorsky
Copy link

+1

Would love this update as well.

@Ken-vdE
Copy link

Ken-vdE commented Dec 20, 2022

This is one of my biggest current issues. I can't count the amount of times i've ctrl-c'd the wrong running command because warp did not focus the pane I clicked. Very annoying.
Is there a ETA on this fix?

@dannyneira
Copy link
Member

@Ken-vdE It is something we've begun work on, but no solid ETA on the fix. Thanks for your patience!

@ScopeSV
Copy link

ScopeSV commented Jan 10, 2023

I usually have multiple panes open, one might be vim, another one is running w/e I'm developing.
I have to manually click on the pane running vim if its not selected. This can also lead to quitting the program, as some shortcuts might be pressed. I'm running everything through the terminal as I really don't enjoy clicking around with the mouse that much. This makes an extra click step which is very prone to errors :)

@AshMcConnell
Copy link

Would love this to be fixed, it can be quite dangerous to type in the wrong window

@degecko
Copy link

degecko commented Feb 9, 2023

Can you please provide this as an option if you can't make it the default bahaviour? It's really bothering in terms of UX. I'm constantly writing in the wrong terminal.

@dannyneira
Copy link
Member

dannyneira commented Mar 1, 2023

Hey Folks, Edited to include Tabs as well as Panes since the behavior is the same when foregrounding.

Also, this is on the roadmap as a future feature/enhancement for Warps foregrounding functionality. No ETA on the launch but it's on our radar. 🤞

@tylerstillwater
Copy link

Adding my two cents on this. This is the #1 disruptor of my daily workflow, and my biggest driver away from Warp. Warp is so good that I'm putting up with it for now, but I would be delighted to see this enhancement happen!

@cdcasey
Copy link

cdcasey commented Jun 9, 2023

Absolute +1. Thanks for looking at the feedback, y'all!

@deep-blue-pulsar
Copy link

deep-blue-pulsar commented Jun 9, 2023

Unfortunately this is too big of an issue for my workflow so I moved back to iterm+fig.

@zachlloyd
Copy link
Contributor

I'm working on a fix for this now.

here's the version for panes: https://share.getcloudapp.com/wbuLJlnp

just noticed this is also an issue for tabs - looking to see if i can fix that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests