Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MITMProxy take over the full session (i.e. no Warp blocks, no shell prompts, no Warp interaction in general) #4635

Open
metal-gabe opened this issue Mar 25, 2024 · 5 comments
Labels
Feature requests Feature Requests

Comments

@metal-gabe
Copy link

Discord username (optional)

No response

Describe the solution you'd like?

When running MITMProxy, it's a weird experience to focus their flows, events, and other actions because Warp's blocks are kind of interfering.

The solution I'd like to see is that when running MITM, to disable blocks as a whole and have MITM take over the whole "interface".

Meaning, that all mouse & keyboard actions are interpreted and passed through as MITM context actions.

This would of course only apply to the window, session, editor, tab (?) that MITM is running in. If another session is focused, then mouse & keyboard actions operate under the context of that session.

Is your feature request related to a problem? Please describe.

This feature request/bug fix that I'm proposing is likely related to these two issues:

Additional context

No response

How important is this feature to you?

3

Warp Internal (ignore) - linear-label:39cc6478-1249-4ee7-950b-c428edfeecd1

None

@metal-gabe metal-gabe added the Feature requests Feature Requests label Mar 25, 2024
@metal-gabe metal-gabe changed the title Make MITMProxy take over the full window (i.e. no Warp blocks, no Warp in interaction in general) Make MITMProxy take over the full session (i.e. no Warp blocks, no shell prompts, no Warp in interaction in general) Mar 25, 2024
@dannyneira
Copy link
Member

hey @gflujan thanks for submitting, any chance that brew install mitmproxy works for you? Are you still seeing the issues with mitmproxy ( no mouse and key bind support )?

To anyone else interested in this feature, please add a 👍 to the original post at the top to signal that you want this feature, and subscribe if you'd like to be notified.

@metal-gabe
Copy link
Author

metal-gabe commented Mar 26, 2024

Hi @dannyneira, thank you for the response.

I am using the Homebrew-installed version of MITM.

I still see issues regarding mouse & key binds not being recognized in Warp.

Here are some specific steps I go through when encountering issues.

  1. I have two windows/apps open: VS Code on my right monitor and Warp on the left monitor (the monitor location of each app doesn't matter, I just added them for visualization)
  2. When I have VS Code focused and then click on the Warp window (with MITM running), the mouse and keyboard actions don't register in MITM
  3. So then I click on the Warp window again (sometimes I have to click twice), this time it selects the "block" that is the entire interface of MITM
  4. Arrow actions register, but...
  5. Up & down arrows scroll the window because there is still a shell prompt above MITM
  6. The right arrow does nothing
  7. The left arrow will unselect the block and allow MITM actions to work at that point
  8. Instead of the left arrow, if I press escape while the block is highlighted this triggers the exit flow for MITM
  9. I have to say "no" to that and then MITM actions start to work
  10. After getting actions to work again, if I click back to VS Code and then click back to MITM/Warp, nothing registers again
  11. For step 10, if I cmd+tab instead of clicking back to MITM/Warp, the actions still register, but this only works if you went through the steps above to get the actions working

So, it seems, the main culprit (for my issue at least) is that clicking on an un-focused MITM/Warp window doesn't immediately register MITM actions.

My feature request to remove blocks may or may not fix this, but I suggested it nonetheless. 🙂

Overall, MITM in Warp is just kind of a clunky experience. It's doable, but not smooth.

@metal-gabe metal-gabe changed the title Make MITMProxy take over the full session (i.e. no Warp blocks, no shell prompts, no Warp in interaction in general) Make MITMProxy take over the full session (i.e. no Warp blocks, no shell prompts, no Warp interaction in general) Mar 26, 2024
@metal-gabe
Copy link
Author

As an additional note, a similar thing happens when I'm watching/running unit tests. Clicking on the Warp window doesn't register the Jest/Vitest actions until I select/click on the block.

@metal-gabe
Copy link
Author

Another piece of "evidence" (?), if I click on the un-focused MITM/Warp, switch to a different tab, then switch back, the actions register.

@dannyneira
Copy link
Member

Oh thanks for the detailed issues with MITM proxy. The issue with focusing on the window may be related to this #739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature requests Feature Requests
Projects
None yet
Development

No branches or pull requests

2 participants