fix: generate exception if codec/layer versions or channel headers are unrecognized #36
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks (once again) for the useful library we use over at the Nextcloud project!
While looking into nextcloud/server#44573, I noted we might as well throw an informative exception if the
codecVersion
,layerVersion
, orchannel
headers are unrecognized.We're going to error out anyway when we try to use empty values for the array key. Instead of generating generic PHP errors when we go to set the
bitRate
andsampleRate
orvbr_offset
we can leave the user a bit less confused about the underlying cause.I don't even know what MP3s might cause this, but seems reasonable to handle this situation cleanly if possible. :)