Adding url to setCookie option + making auth fields optional

wanteddev · May 31, 2021 · 1e3cf62 · 1e3cf62
1 parent 58baac7
commit 1e3cf62
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/routes/index.js b/src/routes/index.js
@@ -220,10 +220,10 @@ router.post('/receive_submission', async function(req, res) {
             values[key].audit_options.selected_options.forEach(option => {
                 submission[option.value] = true;
             });
-        }
-
-        for (const optionKey of Object.keys(values[key])) {
-            submission[optionKey] = values[key][optionKey].value;
+        } else {
+            for (const optionKey of Object.keys(values[key])) {
+                submission[optionKey] = values[key][optionKey].value;
+            }
         }
     }
 

diff --git a/src/utils/lighthouse.js b/src/utils/lighthouse.js
@@ -36,7 +36,7 @@ async function launchPuppeteer(url, options) {
         }
 
         if (options.cookie_name && options.cookie_value) {
-            page.setCookie({ name: options.cookie_name, value: options.cookie_value });
+            page.setCookie({ name: options.cookie_name, value: options.cookie_value, url });
         }
 
         await page.waitForNavigation();

diff --git a/src/utils/responseBuilder.js b/src/utils/responseBuilder.js
@@ -125,6 +125,7 @@ function generateAuditDialog(is_schedule) {
 
     const auth_header = {
         type: 'input',
+        optional: true,
         element: {
             type: 'plain_text_input',
             action_id: 'auth_header',
@@ -142,6 +143,7 @@ function generateAuditDialog(is_schedule) {
 
     const cookie_name = {
         type: 'input',
+        optional: true,
         element: {
             type: 'plain_text_input',
             action_id: 'cookie_name',
@@ -159,6 +161,7 @@ function generateAuditDialog(is_schedule) {
 
     const cookie_value = {
         type: 'input',
+        optional: true,
         element: {
             type: 'plain_text_input',
             action_id: 'cookie_value',