Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): watcher2 => watcher #7622

Merged
merged 2 commits into from May 12, 2024

Conversation

timoffex
Copy link
Contributor

Description

Renames the watcher2 package because the watcher package it replaced is finally deleted.

Created using spr 1.3.5
@timoffex timoffex requested a review from a team as a code owner May 10, 2024 07:43
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.82%. Comparing base (865a816) to head (4251b52).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7622      +/-   ##
==========================================
+ Coverage   75.80%   75.82%   +0.02%     
==========================================
  Files         502      502              
  Lines       54048    54048              
==========================================
+ Hits        40970    40982      +12     
+ Misses      12671    12659      -12     
  Partials      407      407              
Flag Coverage Δ
func 41.15% <ø> (+<0.01%) ⬆️
system 63.47% <100.00%> (+0.02%) ⬆️
unit 56.40% <50.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/internal/runfiles/runfiles.go 100.00% <ø> (ø)
core/internal/runfiles/uploader.go 78.94% <ø> (ø)
core/internal/watcher/impl.go 78.65% <ø> (ø)
core/internal/watcher/watcher.go 100.00% <ø> (ø)
core/internal/watchertest/watchertest.go 50.00% <ø> (ø)
core/pkg/server/sender.go 71.41% <ø> (ø)
core/pkg/server/stream.go 97.02% <100.00%> (ø)
core/pkg/server/stream_init.go 94.80% <ø> (ø)
core/pkg/server/tb.go 22.41% <ø> (ø)
core/internal/runfilestest/runfilestest.go 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

Created using spr 1.3.5
@timoffex timoffex merged commit 5d0644b into main May 12, 2024
6 of 26 checks passed
@timoffex timoffex deleted the spr/timoffex/chorecore-watcher2-watcher branch May 12, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants