Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(artifacts): add save() method on ArtifactCollection to allow persisting changes #7528

Merged
merged 13 commits into from May 20, 2024

Conversation

amusipatla-wandb
Copy link
Contributor

@amusipatla-wandb amusipatla-wandb commented May 1, 2024

Description

This PR pulls the description and tags fields, and allows changes to be made and saved directly via the save function

  • I updated CHANGELOG.md, or it's not applicable

Testing

Tested locally to make sure description and tags were pulled correctly, added integration tests for saving

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 96.47059% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.84%. Comparing base (0383350) to head (11c3729).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7528      +/-   ##
==========================================
+ Coverage   74.27%   75.84%   +1.56%     
==========================================
  Files         500      500              
  Lines       55658    54121    -1537     
==========================================
- Hits        41342    41046     -296     
+ Misses      13907    12668    -1239     
+ Partials      409      407       -2     
Flag Coverage Δ
func 40.84% <30.58%> (-0.49%) ⬇️
system 63.50% <96.47%> (+0.03%) ⬆️
unit 56.36% <30.58%> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/apis/public/artifacts.py 92.94% <96.47%> (+1.59%) ⬆️

... and 105 files with indirect coverage changes

@amusipatla-wandb amusipatla-wandb marked this pull request as ready for review May 3, 2024 21:01
@amusipatla-wandb amusipatla-wandb requested a review from a team May 3, 2024 21:01
wandb/apis/public/artifacts.py Outdated Show resolved Hide resolved
wandb/apis/public/artifacts.py Outdated Show resolved Hide resolved
wandb/apis/public/artifacts.py Outdated Show resolved Hide resolved
wandb/apis/public/artifacts.py Outdated Show resolved Hide resolved
@amusipatla-wandb amusipatla-wandb requested review from moredatarequired and a team May 10, 2024 00:03
Copy link
Contributor

@moredatarequired moredatarequired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

wandb/apis/public/artifacts.py Show resolved Hide resolved
wandb/apis/public/artifacts.py Outdated Show resolved Hide resolved
@amusipatla-wandb amusipatla-wandb requested a review from a team as a code owner May 17, 2024 19:58
@amusipatla-wandb amusipatla-wandb changed the title feat(artifacts): add description and tags fields to ArtifactCollection feat(artifacts): add save() method on ArtifactCollection to allow persisting changes May 17, 2024
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
@amusipatla-wandb amusipatla-wandb merged commit 15f4422 into main May 20, 2024
42 checks passed
@amusipatla-wandb amusipatla-wandb deleted the amusipatla/artifact-collection-pull-fields branch May 20, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants