Skip to content

Commit

Permalink
Remove some other extra junk
Browse files Browse the repository at this point in the history
  • Loading branch information
moredatarequired committed Apr 6, 2024
1 parent ca8563b commit 910ecd0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
2 changes: 0 additions & 2 deletions core/internal/filetransfer/file_transfer_default.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ func NewDefaultFileTransfer(
func (ft *DefaultFileTransfer) Upload(task *Task) error {
ft.logger.Debug("default file transfer: uploading file", "path", task.Path, "url", task.Url)


// open the file for reading and defer closing it
file, err := os.Open(task.Path)
if err != nil {
Expand Down Expand Up @@ -106,7 +105,6 @@ func (ft *DefaultFileTransfer) Upload(task *Task) error {
}
req.Header.Set(parts[0], parts[1])
}

if task.Context != nil {
req = req.WithContext(task.Context)
}
Expand Down
3 changes: 1 addition & 2 deletions core/pkg/artifacts/saver.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"net/url"
"os"
"strings"
"sync"
"time"

"github.com/Khan/genqlient/graphql"
Expand Down Expand Up @@ -148,7 +147,7 @@ func (as *ArtifactSaver) uploadFiles(artifactID string, manifest *Manifest, mani
// Upload in batches.
numInProgress, numDone := 0, 0
nameToScheduledTime := map[string]time.Time{}
taskResultsChan := make(chan TaskResult, 1000)
taskResultsChan := make(chan TaskResult)
fileSpecsBatch := make([]gql.CreateArtifactFileSpecInput, 0, batchSize)
for numDone < len(fileSpecs) {
// Prepare a batch.
Expand Down
1 change: 0 additions & 1 deletion tests/pytest_tests/system_tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,6 @@ def spin_wandb_server(settings: WandbServerSettings) -> bool:
"linux/amd64",
f"{settings.wandb_server_image_registry}/{settings.wandb_server_image_repository}:{settings.wandb_server_tag}",
]
print(" ".join(command))
subprocess.Popen(command)
# wait for the server to start
server_is_up = check_server_health(
Expand Down

0 comments on commit 910ecd0

Please sign in to comment.