Mobs #335
Mobs #335
Conversation
|
This is an extensive contribution. Thanks! @walterhiggins will need to comment. There are many parts to this. It will take time to separate the pieces and figure them out. Personally I think it would be very helpful to have some context for these changes. Some documentation would help. This info is probably already in the PDF (which is really great). But it's tough to link specific concepts to code.
If you provide info here or with notes added into a commit on the code, we can move toward an understanding of the code and incorporation of the features. I think extensive changes like this might be good for a v3.3 Beta. |
|
The Russian version of the Young Peoples' Guide is also amazing (Spacibo!). The guide is generated from src/docs/templates/ypgpm.md. We can move the RU_ version to templates/ru_ypgpm.md and then modifiy the build process to include it. As the English documentation changes, we don't want docs in other languages to fall behind. This is a common problem in projects like this. The common solution is to have files for each language, and for triggers to update contributors when content changes. People then offer their changes and each language version of the doc gets updated "automatically". I propose that a general solution to multi-language/polygot documentation be added to the project, and then in v3.4 this Russian translation can serve as a test base - and all of this fine content can finally find a home in the project. I can drive this but I'd like thoughts from @walterhiggins first. |
|
Thanks for this @Ignat99 - could you perhaps split this out into a couple of smaller PRs? It's difficult to get a sense of the overall purpose of these changes. Also - some changes seem to be from other non-core scriptcraft-related repos. For example the wolfbot presented in this PR seems similar to https://github.com/cacciatc/wolfbot/blob/master/bot/bot.js |
Two mobs, that i fix for current version of ScriptCraft.