Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update Vite, TypeScript and React dependencies react-ts template #3433

Conversation

DiegPS
Copy link
Contributor

@DiegPS DiegPS commented Apr 26, 2024

Description

Updated to the new versions of TypeScript, Vite and React, because currently there are libraries that as minimum version in typescript ask for version 5, and only with updating to the latest version of typescript they work correctly, which can generate confusion that it is the fault of wails, when it is only a question that the template does not have TypeScript 5.

Fixes # (#2198)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Windows
  • macOS
  • Linux

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@leaanthony
Copy link
Member

Thanks for opening this. We've had problems upgrading to v5 as it's broken dev mode. Are you able to generate a new project with these changes and have dev mode work?

@leaanthony leaanthony added the awaiting feedback More information is required from the requestor label May 5, 2024
@DiegPS
Copy link
Contributor Author

DiegPS commented May 6, 2024

in my case, I have no problems with this setup in “windows”, but as I am not aware of how it may affect other systems, maybe we could even in the template in the specific readme place that you are using a certain version of TypeScript, Vite or React, something similar to a disclaimer, so maybe somewhere in the readme either in “about, live development or building” mention that you may be forced to update the frontend dependencies manually to work properly.

@DiegPS DiegPS closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback More information is required from the requestor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants