New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icon issues with windows when project name contains spaces #3400
Conversation
WalkthroughThe changes involve updating file paths in Changes
Possibly related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
### Fixed | ||
- Fixed an issue with missing icon for Windows. Fixed by [@APshenkin](https://github.com/wailsapp/wails/pull/3400) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the link to the GitHub user @APshenkin is correctly formatted. It currently appears to be a link to a pull request rather than a user profile.
Thanks for opening this. What a curious issue! |
@leaanthony curious when this will be merged? |
Done! |
Description
Recently I discovered weird issue related to
.syso
files. To add icons to binary wails creates syso file that then used by go compiler to build the app. There is weird issue with a case when you have space symbol at syso filename at 15 position (0 first element). In that case for some reasons syso file is not taken. I know, this sounds weird, and I even don't know where to report this 馃槄So I replaced spaces in
syso
file name to underscores. This solves the issueType of change
Please delete options that are not relevant.
How Has This Been Tested?
Create wails template project and put
aaaaaaaaaaaaaaa a
asname
property inwails.json
Build windows app
Test Configuration
Please paste the output of
wails doctor
. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdx
with details of this PRSummary by CodeRabbit