Comment out django_debug_toolbar settings from dev settings #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version (4.4.2) of django-debug-toolbar aborts when running ./manage.py test with the toolbar enabled. While bakerydemo doesn't have any tests, .github/workflows/docker.yml runs this anyway, presumably as a sort of sanity check, and thus we need to properly disable django-debug-toolbar rather than just leaving it inactive via INTERNAL_IPS. (The `__debug__` route is still defined in bakerydemo.urls, but this seems to be harmless.)
gasman
force-pushed
the
fix/django-debug-toolbar-testing
branch
from
05f3234
to
4f67764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version (4.4.2) of django-debug-toolbar aborts when running ./manage.py test with the toolbar enabled. While bakerydemo doesn't have any tests, .github/workflows/docker.yml runs this anyway, presumably as a sort of sanity check, and thus we need to properly disable django-debug-toolbar rather than just leaving it inactive via INTERNAL_IPS.
(The
__debug__route is still defined in bakerydemo.urls, but this seems to be harmless.)