Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim like arrow, scroll, and close filtering motions #501

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mehmetumit
Copy link

@mehmetumit mehmetumit commented Jan 28, 2024

With this pull request, some of the key controls discussed in #129 will be implemented.

  • Adding configurable keybindings for up/down arrows ( k and j vim motions can be used as alternative to up/down arrows) Thanks to @gwendolyngoetz for implementing this feature Adding configurable keybindings for up/down arrows #499
  • Add configurable keybindings for left/right arrows ( h and l vim motions can be used as alternative to left/right arrows)
  • Add u and d keys for page up/down alternatives ( I didn't want to replace default ctrl+u toggle-unmodified-files keybinding so I usedu and d like Vimium extension )
  • Add esc key to close filtering( Implemented a new method by utilizing the existing toggle filter method, without touching its current behavior)

Additionally, once awesome-gocui/keybinding#5 is merged, it will be possible to use characters like ö, ü, / . As a result, #129 and #415 issues will be completely solved.

@mehmetumit mehmetumit changed the title Add vim like arrow and scroll motions Add vim like arrow, scroll, and close filtering motions Jan 29, 2024
@mehmetumit
Copy link
Author

Is there any update? Could you please take a look when you get a chance, @wagoodman ? Let me know if there's anything else you need from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants