feat: Add layer-wise filesystem information to the analysis json file #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagoodman
reviewed
Jul 7, 2023
runtime/export/layer.go
Outdated
| DigestID string `json:"digestId"` | ||
| SizeBytes uint64 `json:"sizeBytes"` | ||
| Command string `json:"command"` | ||
| FileList []filetree.NodeData `json:"fileList"` |
There was a problem hiding this comment.
instead of NodeData which shows the view information as well, should this be FileInfo instead?
There was a problem hiding this comment.
Yes currently, the FileList will contain the ViewInfo, which can be seen in the testcase here- https://github.com/Akash-Nayak/dive/blob/f1783c55b3d7bc02d5e9cbb681d25044998375cc/runtime/export/export_test.go#L28.
Should I make the changes so that it only contains the FileInfo?
There was a problem hiding this comment.
instead of NodeData which shows the view information as well, should this be FileInfo instead?
Hi @wagoodman, I have changed it from NodeData to FileInfo.
wagoodman
force-pushed
the
add-filesystem-to-json
branch
from
54ddae2
to
f1783c5
Compare
|
note: forced pushed to rebase the branch for CI updates / conflicts |
Akash-Nayak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally PR #342