Correctly match * as a host-part.
#657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for `*` to the `host-part` matching algorithm, allowing patterns like `https://*:123` to correctly match any host.
|
Adding a test in https://chromium-review.googlesource.com/c/chromium/src/+/5471523. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 22, 2024
This tests the change made in w3c/webappsec-csp#657. Bug: 334278797 Change-Id: I7ecab785ac44456af00d0ec1af3f6d09aac02782
antosart
approved these changes
Apr 23, 2024
|
Makes sense to me. (Currently in Firefox we disallow certain schemes for *, but that is already handled in earlier steps in the spec) |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 24, 2024
This tests the change made in w3c/webappsec-csp#657. Bug: 334278797 Change-Id: I7ecab785ac44456af00d0ec1af3f6d09aac02782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471523 Reviewed-by: Antonio Sartori <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1291742}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 24, 2024
This tests the change made in w3c/webappsec-csp#657. Bug: 334278797 Change-Id: I7ecab785ac44456af00d0ec1af3f6d09aac02782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471523 Reviewed-by: Antonio Sartori <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1291742}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 24, 2024
This tests the change made in w3c/webappsec-csp#657. Bug: 334278797 Change-Id: I7ecab785ac44456af00d0ec1af3f6d09aac02782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471523 Reviewed-by: Antonio Sartori <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1291742}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 29, 2024
…st-part`., a=testonly Automatic update from web-platform-tests CSP: Add a test for `*` in pattern's `host-part`. This tests the change made in w3c/webappsec-csp#657. Bug: 334278797 Change-Id: I7ecab785ac44456af00d0ec1af3f6d09aac02782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471523 Reviewed-by: Antonio Sartori <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1291742} -- wpt-commits: d0649743f613ff12c570642bd1782433d1b0d390 wpt-pr: 45816
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Apr 30, 2024
…st-part`., a=testonly Automatic update from web-platform-tests CSP: Add a test for `*` in pattern's `host-part`. This tests the change made in w3c/webappsec-csp#657. Bug: 334278797 Change-Id: I7ecab785ac44456af00d0ec1af3f6d09aac02782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471523 Reviewed-by: Antonio Sartori <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1291742} -- wpt-commits: d0649743f613ff12c570642bd1782433d1b0d390 wpt-pr: 45816
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jun 1, 2024
…st-part`., a=testonly Automatic update from web-platform-tests CSP: Add a test for `*` in pattern's `host-part`. This tests the change made in w3c/webappsec-csp#657. Bug: 334278797 Change-Id: I7ecab785ac44456af00d0ec1af3f6d09aac02782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5471523 Reviewed-by: Antonio Sartori <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1291742} -- wpt-commits: d0649743f613ff12c570642bd1782433d1b0d390 wpt-pr: 45816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
*to thehost-partmatching algorithm, allowing patterns likehttps://*:123to correctly match any host.Fixes #656