Update G195 - removal of last line of test (low contrast OK if focus ring > 2px thick) #3686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deletion of last line of test procedure that indicated that contrast below 3:1 is OK if the border is more than 2px thick
patrickhlauke
approved these changes
Feb 12, 2024
|
Discussed on TF call 11/8 and moved to Ready for approval after Patrick offered to double check. |
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@patrickhlauke and @detlevhfischer please see my comments #3682 . I believe we need to decide whether we are to maintain two versions of G195. Either way, we need more changes in the Test (unless we are intentionally exceeding the Non-text Contrast requirements). Also, if we decide not to apply this technique to 2.4.13 in 2.2, we need to make adjustments to the Understanding document to remove the mapping. |
|
@kfranqueiro I'm just bringing this one to your attention, as it may be relevant to your 2.1 update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletion of last line of test procedure that indicated that contrast below 3:1 is OK if the focus ring is more than 2px thick
Closes #3682