Skip to content

Conversation

christianliebel
Copy link
Member

@christianliebel christianliebel commented Apr 24, 2025

Closes #925

This change (choose at least one, delete ones that don't apply):

  • Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)

Commit message:

Editorial: rephrase multiple icon example

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

  • chore:
  • editorial:
  • BREAKING CHANGE:
  • And use none if it's a normative change

Preview | Diff

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some suggestion, but they are mostly optional. Text seems ok regardless.

@dmurph
Copy link
Collaborator

dmurph commented May 1, 2025

change looks good to me as well

@christianliebel christianliebel merged commit 8ff396e into main May 5, 2025
2 checks passed
@christianliebel christianliebel deleted the rephrase-size-example branch May 5, 2025 15:02
github-actions bot added a commit that referenced this pull request May 5, 2025
SHA: 8ff396e
Reason: push, by christianliebel

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example suggests that icons sizes mean a minimum size, but normative text doesn't support that
3 participants