-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Add installable web application definition #1163
Conversation
Co-authored-by: Marcos Cáceres <[email protected]>
SHA: 2d9f760 Reason: push, by marcoscaceres Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was merged very quickly! (Edit: I'm assuming during the Manifest working session late last night GMT).
I have some suggestions.
This distinguishes an installed web application from a traditional | ||
bookmark, as opening a web page from a traditional bookmark will not | ||
have the manifest's properties <a>applied</a> to it. | ||
Any website is an <strong>installable web application</strong>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If an "installed web application" is defined as a web application whose manifest members have been (or can be) applied to a top level browsing context, then how can a website with no manifest be an "installable web application"?
Surely a web application must at least have a web app manifest in order to be considered installable?
Also, is it the view of the Web Applications Working Group that all websites are web applications?
See also: #1097
<p>Once a web application is [=installed=] it is known as a | ||
<dfn class="export">installed web application</dfn>: | ||
That is, the manifest's members, or their defaults, | ||
are [=applied=] to the <a>top-level browsing context</a> of the web application. This | ||
distinguishes an installed web application from a traditional bookmark, | ||
as opening a web page from a traditional bookmark will not have the | ||
manifest's properties <a>applied</a> to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once a web application is installed it is known as a[sic] installed web application: That is, the manifest's members, or their defaults, are applied to the top level browsing context of the web application.
This could be refined to say that when the app is launched the manifest's members will be applied to the top level browsing context.
Currently it reads to me like an installed web application is one whose manifest has been applied to a top-level browsing context. But actually installing a web app and launching a web app may be two separate steps as described in the following note. A web application which has been added to an app launcher but not yet launched may still be considered "installed".
(My implementation of Web App Manifest actually installs a web app and applies the manifest in one step, but AFAIK that's not the case for most implementations.)
Closes #1097
This change (choose at least one, delete ones that don't apply):
Commit message:
Adds a formal definition for 'installable web application'.
Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:
Preview | Diff