[css-scroll-snap-2] Add snap event handler attributes for Document and Element #10215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Element This adds the onsnapchanged and onsnapchanging attributes to the css-scroll-snap-2 specification for elements and Document objects. Heavily influenced by css-animations extensions to GlobalInterfaceHandlers[1]. [1] https://drafts.csswg.org/css-animations/#interface-globaleventhandlers
DavMila
changed the title
flackr
reviewed
May 7, 2024
css-scroll-snap-2/Overview.bs
Outdated
| <td><dfn>onsnapchanging</dfn></td> | ||
| <td>{{snapchanging}}</td> | ||
| </table> | ||
|
|
There was a problem hiding this comment.
I think these additions to the html spec would belong in an appendix as a modification of the the particular spec section, specifically https://html.spec.whatwg.org/#event-handlers-on-elements,-document-objects,-and-window-objects in this case. E.g. in the scroll-animations spec we have two animation concepts in the appendix labeled as should be moved to the relevant web-animations and css-animations specs: https://drafts.csswg.org/scroll-animations-1/#timeline-ranges
There was a problem hiding this comment.
Thanks for the link. Done.
Move to appendix; point to html spec.
flackr
approved these changes
May 9, 2024
Clarify that event handlers are additional attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add snap event handler attributes for Document and Element
This adds the onsnapchanged and onsnapchanging attributes to the css-scroll-snap-2 specification for elements and Document objects.
Heavily influenced by css-animations' extensions to GlobalInterfaceHandlers.