Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mediaqueries] Lift <media-feature> parens to <media-in-parens> (#6806) #10131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdoublev
Copy link
Collaborator

This PR applies 1af56e0 to MediaQueries 5. This commit was made 3 years ago, after initiating from MediaQueries 4.

Also, the railroad diagram of the updated syntax was not updated accordingly. This PR updates it in both levels of the spec.


Without this change, a container size query will match <general-enclosed> and evaluate to unknown, unless it is specified in two ()-blocks, because <query-in-parens> (CSS Contain) produces ( <size-feature> ), and <size-feature> is defined as "the same as for a media feature: a feature name, a comparator, and a value". (Note that you do not always have a comparator, eg. orientation: portrait.)

Besides, I assume that media-progress(<media-feature>, ...) and container-progress(<size-feature>, ...) are supposed to accept/take a query without using a ()-block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant