Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify multiple configURLs #667

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Specify multiple configURLs #667

merged 5 commits into from
Nov 26, 2024

Conversation

cbiesinger
Copy link
Collaborator

@cbiesinger cbiesinger commented Oct 28, 2024

Bug: #552


Preview | Diff

Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All to increase clarity.

spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
@cbiesinger
Copy link
Collaborator Author

Thanks @TallTed, done. (Some of the lines you commented on aren't new, I just changed the indentation)

spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@cbiesinger cbiesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take another look!

spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
@cbiesinger cbiesinger added the agenda+ Regular CG meeting agenda items label Nov 13, 2024
@npm1
Copy link
Collaborator

npm1 commented Nov 26, 2024

Merging based on the WG discussion.

@npm1 npm1 merged commit 8201e01 into w3c-fedid:main Nov 26, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Nov 26, 2024
SHA: 8201e01
Reason: push, by npm1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hlflanagan
Copy link
Contributor

@cbiesinger cbiesinger deleted the configurls branch November 26, 2024 17:32
@cbiesinger cbiesinger removed the agenda+ Regular CG meeting agenda items label Nov 26, 2024
github-actions bot added a commit to mattdanielbrown/WebID that referenced this pull request Nov 26, 2024
SHA: 8201e01
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants