Add support to show only top-level origin when calling from an iframe #464
Conversation
| @@ -22,6 +22,10 @@ Test Suite: https://github.com/web-platform-tests/wpt/blob/master/credential-man | |||
| </pre> | |||
|
|
|||
| <pre class=anchors> | |||
| spec: html; urlPrefix: https://html.spec.whatwg.org/multipage | |||
There was a problem hiding this comment.
This is now exported from HTML (filed a bug about it), but hasnt reached bikeshed yet.
|
Addressed comments, let me know what you think |
|
Thanks! Algorithm LGTM. |
|
@martinthomson @cboozar @bvandersloot-mozilla please take a look. Per your request, not filing an official Mozilla standards position but you can consider this to be it. As discussed in the call, we would like to ship this on Chrome 115, which branches in May 23 so we'll send I2S perhaps a week or so before then. |
|
Makes sense to me, though I want to understand why the urgency for 115, who is consuming this ATM? |
I'm not merging this yet, as there are concerns about the API shape being discussed in the issue. The urgency for 115 is for Google Identity Services (right now, if they want a website to use FedCM within an iframe, Chrome will force the dialog to show three origins, whereas the site will most likely prefer showing only two if possible, to provide better UX). I'm not confident we'll be shipping in that milestone though, we'll keep people updated in the issue. |
|
I am closing this as we're not moving forward with this proposal. |
This PR fixes the client metadata fetch by passing the client ID in the query, and fixes #449 by adding the proposed logic.
Preview | Diff