Skip to content

Commit

Permalink
Editorial fixes (#690)
Browse files Browse the repository at this point in the history
* reb

* Editorial fixes

* feedback
  • Loading branch information
npm1 authored Jan 13, 2025
1 parent 9fb61a2 commit fdb085e
Showing 1 changed file with 14 additions and 13 deletions.
27 changes: 14 additions & 13 deletions spec/index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ spec:webidl; type:dfn; text:resolve
spec:webdriver2; type:dfn; text:error
spec:webdriver2; type:dfn; text:remote end steps
spec:fetch; type:dfn; for:/; text:response
spec:css-color-5; type:type; text:<color>
</pre>

<style>
Expand Down Expand Up @@ -786,18 +787,18 @@ or a pair (failure, bool), where the bool indicates whether to skip delaying
the exception thrown.
1. Assert: These steps are running [=in parallel=].
1. Let |mode| be |options|'s {{IdentityCredentialRequestOptions/mode}}.
1. If |mode| is [=active=]:
1. Let |W| be |globalObject|'s [=associated Window=].
1. If |W| does not have [=transient activation=], return (failure, true).
1. Otherwise, if there is a pending request where |mode| is [=passive=]
on |W|'s [=Window/navigable=]'s [=navigable/top-level traversable=]
or on any of its descendants, reject the pending request with a
"{{NetworkError}}" {{DOMException}}.
1. If |mode| is {{IdentityCredentialRequestOptionsMode/active}}:
1. Assert: |globalObject| is a {{Window}}.
1. If |globalObject| does not have [=transient activation=], return (failure, true).
1. Otherwise, if there is a pending request where {{IdentityCredentialRequestOptionsMode}} is
{{IdentityCredentialRequestOptionsMode/passive}} on |globalObject|'s [=Window/navigable=]'s
[=navigable/top-level traversable=] or on any of its descendants, reject the pending
request with a "{{NetworkError}}" {{DOMException}}.
1. Let |loginStatus| be the result of [=get the login status=] with
the [=/origin=] of |provider|'s {{IdentityProviderConfig/configURL}}.
1. If |loginStatus| is [=unknown=], a user agent MAY set it to [=logged-out=].
1. If |loginStatus| is [=logged-out=]:
1. If |mode| is [=active=]:
1. If |mode| is {{IdentityCredentialRequestOptionsMode/active}}:
1. Let |result| be the result of running
[=fetch the config file and show an IDP login dialog=] with
|provider| and |globalObject|.
Expand Down Expand Up @@ -917,7 +918,7 @@ the exception thrown.
[=compute the connection status/connected=], set |permission| to true.
1. Otherwise, if |provider|.{{IdentityProviderRequestOptions/fields}} is [=list/empty=],
[=create a connection between the RP and the IdP account=] with |provider|, |account|,
and |globalObject|, and set |permission| to |true|.
and |globalObject|, and set |permission| to true.

Note: The connection would normally be created in the [=request permission to sign-up=]
algorithm, but we do not want to show an extra dialog in this case.
Expand Down Expand Up @@ -1407,7 +1408,7 @@ an {{IdentityProviderAPIConfig}} |config|, an {{IdentityProviderRequestOptions}}

Any other string is ignored for forwards compatibility.
1. The user agent MAY use the
{{IdentityCredentialRequestOptions/context}} and |options|'s
{{IdentityCredentialRequestOptions/context}} and |provider|'s
{{IdentityCredentialRequestOptions/mode}} to customize the dialog shown.
1. If the user does not grant permission, return false.
1. Return true.
Expand Down Expand Up @@ -1888,7 +1889,7 @@ developer provides an icon that is not square, the [=user agent=] may choose to
all, trim the icon and show a square portion of it, or even transform it into a square icon and show
that.

The <dfn>color</dfn> is a subset of CSS <<color>> syntax, namely <<hex-color>>s, ''hsl()''s, ''rgb()''s and <<named-color>>.
The {{IdentityProviderBranding/color}} is a subset of CSS <<color>> syntax, namely <<hex-color>>s, ''hsl()''s, ''rgb()''s and <<named-color>>.

For example:

Expand Down Expand Up @@ -2552,7 +2553,7 @@ The [=remote end steps=] are:
1. Return [=success=] with data `null`.

<!-- ============================================================ -->
# Security # {#security}
# Security Considerations # {#security}
<!-- ============================================================ -->

This section provides a few of the security considerations for the FedCM API. Note that there is a
Expand Down Expand Up @@ -2625,7 +2626,7 @@ the top-level frame wants it so. A sneaky iframe cannot force the FedCM UI to oc
content from the main page.

<!-- ============================================================ -->
# Privacy # {#privacy}
# Privacy Considerations # {#privacy}
<!-- ============================================================ -->

This section is intended to provide a comprehensive overview of the privacy risks associated with
Expand Down

0 comments on commit fdb085e

Please sign in to comment.