Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: T6877: add a script for merging multiple flavor files #837

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

dmbaturin
Copy link
Member

Change Summary

Add a script for merging multiple flavor definition together.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Utils.

Proposed changes

To build source tarballs for releases, we need a way to collect all packages for all flavors included in a release. The simplest way to do that is likely to automatically produce a "meta-flavor", run its build, collect packages that were pulled from the repos during the build process, and discard the ISO.

This script uses custom (very simple) dict merging in case we need funny fixups down the line. It may be safe to use dict merging functions from vyos-1x, if proven safe, it will be a very simple change.

How to test

./scripts/utils/merge-flavors generic.toml <more files>

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

👍
No issues in PR Title / Commit Title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants