Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6718: use the vyconf daemon for validation of set commands #21

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Oct 26, 2024

Change Summary

This PR has been updated with appropriate commit hashes in build.sh, following merge of
vyos/vyos1x-config#31
vyos/vyconf#11
and is ready for review.

It is required by the corresponding PR for vyos-1x.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyos1x-config#31
vyos/vyconf#11

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro marked this pull request as ready for review November 20, 2024 20:05
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will certainly work, but I wonder if we should package vyconf and its tools separately at a later point.

@jestabro
Copy link
Contributor Author

Now that we have the whole of vyconf available, I expect we will want to refactor the distinction vyconf <-> vyos1x-config as well as packaging.

@jestabro jestabro marked this pull request as draft December 5, 2024 20:39
@jestabro
Copy link
Contributor Author

jestabro commented Dec 5, 2024

This will benefit from a single commit PR for vyos-1x before merging, to make for a smooth transition (as ctypes do not, as far as I know, have a notion of optional argument, we must introduce a keyword argument with default for the python wrapper reference_tree_to_json, to accommodate the change in the underlying function). The remainder of the vyos-1x PR vyos/vyos-1x#4176 will be opened after updates to the Dockerfile, etc.

@jestabro
Copy link
Contributor Author

jestabro commented Dec 6, 2024

After this merge, the update to the Docker file to reflect new commit hash will need to be accompanied by:
vyos/vyos-1x#4226
to avoid a chicken-and-egg problem with build time generation of the reference tree.

@jestabro jestabro marked this pull request as ready for review December 6, 2024 14:47
@jestabro jestabro merged commit 2b979d7 into vyos:current Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants