Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Matcher with param parsing #2415

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

feat: handle children

db5a85c
Select commit
Loading
Failed to load commit list.
Open

New Matcher with param parsing #2415

feat: handle children
db5a85c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 9, 2025 in 0s

77.56% (-17.33%) compared to c73e83f

View this Pull Request on Codecov

77.56% (-17.33%) compared to c73e83f

Details

Codecov Report

Attention: Patch coverage is 33.21617% with 760 lines in your changes missing coverage. Please review.

Project coverage is 77.56%. Comparing base (c73e83f) to head (db5a85c).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
packages/router/src/experimental/router.ts 0.00% 666 Missing and 1 partial ⚠️
packages/router/src/new-route-resolver/resolver.ts 77.59% 54 Missing ⚠️
...uter/src/new-route-resolver/matchers/test-utils.ts 70.83% 21 Missing ⚠️
...s/router/src/new-route-resolver/matcher-pattern.ts 81.25% 12 Missing ⚠️
...s/router/src/new-route-resolver/matchers/errors.ts 54.54% 5 Missing ⚠️
packages/router/src/new-route-resolver/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2415       +/-   ##
===========================================
- Coverage   94.88%   77.56%   -17.33%     
===========================================
  Files          34       41        +7     
  Lines        2993     4069     +1076     
  Branches      845      917       +72     
===========================================
+ Hits         2840     3156      +316     
- Misses        150      908      +758     
- Partials        3        5        +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov