Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): to check ImportMap after deserialize #315

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

wangcch
Copy link
Collaborator

@wangcch wangcch commented Feb 13, 2025

Need to check ImportMap after deserialize because builtinImportMap data will be deleted during store.serialize.

 /**
  * Deserializes the given string to restore the REPL store state.
  * @param serializedState - The serialized state string.
  * @param checkBuiltinImportMap - Whether to check the built-in import map. Default to true
  */
deserialize(serializedState: string, checkBuiltinImportMap?: boolean): void

Copy link

vercel bot commented Feb 13, 2025

@wangcch is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

src/store.ts Outdated Show resolved Hide resolved
@edison1105 edison1105 added the bug Something isn't working label Feb 16, 2025
Copy link

pkg-pr-new bot commented Feb 16, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@vue/repl@315

commit: f07ac99

@wangcch wangcch force-pushed the fix-store-deserialize branch from 82cd1a2 to f07ac99 Compare February 17, 2025 12:07
@edison1105 edison1105 merged commit e62ddda into vuejs:main Feb 17, 2025
2 of 3 checks passed
@wangcch wangcch deleted the fix-store-deserialize branch February 18, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants