Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add core entry for node usage #310

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

Dsaquel
Copy link
Contributor

@Dsaquel Dsaquel commented Jan 24, 2025

add new entries to import compileFile

resolve #304

edit: realised that we couldve import more utilities besides compileFile, thats why i created a new export entry core.ts. The name might be not appropriated though

Copy link

vercel bot commented Jan 24, 2025

@Dsaquel is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

@Dsaquel Dsaquel changed the title feat: add transform entry feat: add core entry for node usage Jan 25, 2025
@yyx990803 yyx990803 force-pushed the main branch 2 times, most recently from 06a2e36 to 41d770d Compare February 3, 2025 04:06
Copy link

pkg-pr-new bot commented Feb 17, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@vue/repl@310

commit: f1795f3

@Dsaquel Dsaquel force-pushed the feat/add-transform-entry branch from c6944e5 to 1255f8a Compare February 17, 2025 08:27
@edison1105 edison1105 requested a review from wangcch February 17, 2025 13:46
@wangcch
Copy link
Collaborator

wangcch commented Feb 17, 2025

🤔 I wonder if there will be duplicate content in vue-repl and core.
Maybe we need to support tree shaking

src/core.ts Outdated Show resolved Hide resolved
@Dsaquel
Copy link
Contributor Author

Dsaquel commented Feb 17, 2025

Maybe we need to support tree shaking

Yes, you right we will have deduplicate imports in the bundled directory and that's normal i think.
At this part its the responsability of the developer to enable treeshake to only use what he use.
note: we handle treeshake because it is enabled by default, thanks to rollup.

@wangcch
Copy link
Collaborator

wangcch commented Feb 18, 2025

Maybe we need to support tree shaking

Yes, you right we will have deduplicate imports in the bundled directory and that's normal i think. At this part its the responsability of the developer to enable treeshake to only use what he use. note: we handle treeshake because it is enabled by default, thanks to rollup.

Rollup's treeshake option focuses on removing unused code within the current bundle.

I mean maybe we can split vue-repl.js . but that's a big change 🤔
like this
image

Copy link
Collaborator

@wangcch wangcch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edison1105 edison1105 merged commit da105a4 into vuejs:main Feb 19, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fail to use compileFile in Node
3 participants