Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-core): loose props check on generic components without strictTemplates #4983

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(language-core): loose props check on generic components without strictTemplates #4983

wants to merge 3 commits into from
+22 −9

Conversation

KazariEX
Copy link
Collaborator

@KazariEX KazariEX commented Nov 4, 2024

fix #4972

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 4, 2024 •
edited
Loading

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4983

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4983

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4983

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4983

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4983

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4983

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4983

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4983

commit: 8c4d461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsoncodehk johnsoncodehk Awaiting requested review from johnsoncodehk johnsoncodehk is a code owner

@so1ve so1ve Awaiting requested review from so1ve so1ve is a code owner

@zhiyuanzmj zhiyuanzmj Awaiting requested review from zhiyuanzmj zhiyuanzmj is a code owner

@KermanX KermanX Awaiting requested review from KermanX KermanX is a code owner

@davidmatter davidmatter Awaiting requested review from davidmatter davidmatter is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing any prop to generic component makes other props not required (defineModel)
1 participant
@KazariEX