Skip to content

refactor: migrate eslint-internal-rules and docs build shims to TypeScript - #3238

Open
ValentinYoushkevich wants to merge 2 commits into
vuejs:masterfrom
ValentinYoushkevich:refactor/ts-internal-rules
Open

ValentinYoushkevich wants to merge 2 commits into
vuejs:masterfrom
ValentinYoushkevich:refactor/ts-internal-rules

Conversation

@ValentinYoushkevich

Copy link
Copy Markdown
Contributor

This is the follow-up promised in #3236 for the internal lint rules and the docs build shims. The three files in eslint-internal-rules/ are now .ts with ESM exports, and eslint.config.mjs imports them directly, so Node runs them through type stripping exactly like the rules in lib/rules, which the config already loads through tools/lib/rules.js. The folder is added to tsconfig.json, so npm run tsc checks it too. In the docs, shim/empty.mjs and src/process-shim.mjs became .ts; they are only consumed by Vite and esbuild, and process-shim.ts uses the same @ts-expect-error -- Browser comments for window as the theme does. Behaviour is unchanged. docs/.vitepress/public/service-worker.js and the integration fixtures' configs stay JavaScript on purpose. The tools/ migration is in #3237.

Part of #2777

@changeset-bot

changeset-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b124976

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant