Repository navigation
feat(define-props-declaration): add autofix to type-based declaration - #3235
Open
ValentinYoushkevich wants to merge 2 commits into
Open
ValentinYoushkevich wants to merge 2 commits into
ValentinYoushkevich wants to merge 2 commits into
Conversation
Convert a runtime defineProps() declaration to a type-based one when the conversion keeps the props' runtime behavior, and skip the fix otherwise.
🦋 Changeset detectedLatest commit: 7683b1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…-declaration-autofix
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This picks up #2466 by @mpiniarski, who agreed to hand it over. It adds an autofix to
vue/define-props-declarationthat turns a runtimedefineProps({...})into a single-line type-based declaration and moves defaults intowithDefaults(). I went through the review there: nothing throws, there is no try/catch, and whatever can't be converted exactly just gets no fix, including array declarations likedefineProps(['kind']),validator, a non-literalrequired, unknown constructors, spreads and comments. Props withoutrequired: truebecome optional,Functionmaps to(...args: any[]) => any, and the separate interface option is gone. I also checked that@vue/compiler-sfcgenerates the same runtime props for the fixed code.Closes #2465