Repository navigation
feat: add ignoreComments option to content newline rules - #3228
Open
ValentinYoushkevich wants to merge 4 commits into
Open
ValentinYoushkevich wants to merge 4 commits into
ValentinYoushkevich wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 51e27bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FloEdelmann
reviewed
Oct 28, 2026
FloEdelmann
reviewed
Oct 29, 2026
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "eslint-plugin-vue": minor | |||
Member
There was a problem hiding this comment.
Let's wait before merging this to have a bugfix-only release first.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues #2581 by dsl101. It adds an
ignoreCommentsoption (defaultfalse) tovue/multiline-html-element-content-newlineand, as Flo asked there, tovue/singleline-html-element-content-newline. With the option on, an HTML comment on the same line as the opening tag, or right before the closing tag, is no longer treated as content, so the line break is checked against the content after or before it. #2581 dropped comments from the token list entirely, which broke the case Flo found: a comment on its own line before an element made the parent report two line breaks. Here comments are only skipped next to the tags, so own-line comments count as before. Autofix never moves or removes a comment.Closes #2179