Repository navigation
feat(match-component-import-name): add ignoreConflictingNames option - #3218
Open
ValentinYoushkevich wants to merge 2 commits into
Open
ValentinYoushkevich wants to merge 2 commits into
ValentinYoushkevich wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 8d067ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ent-import-name-ignore-conflicting # Conflicts: # lib/rules/match-component-import-name.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vue/match-component-import-namewants the registered name to equal the import name, which can't work when that name is already taken in the file. A common case is a component that shares its name with a TypeScript interface or a model class: the import has to be renamed, so you end up withFooBar: FooBarComponent, and the rule reports it. Registering it asFooBarComponentjust to please the rule isn't what anyone wants in the template. PlaygroundAs proposed in the issue, the new
ignoreConflictingNamesoption (defaultfalse) skips a registration whose name, or the PascalCase form of a kebab-case key, is declared in the file, type-only imports and interfaces included. Implicit globals don't count, and other mismatches are still reported.Fixes #2011