Repository navigation
refactor: migrate utils/index to TypeScript - #3208
Merged
FloEdelmann merged 9 commits intoOct 30, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
FloEdelmann
added
the
meta
ValentinYoushkevich
force-pushed
the
refactor/ts-utils-index
branch
from
October 24, 2026 07:12
7445d1d to
287150d
Compare
ValentinYoushkevich
marked this pull request as ready for review
October 25, 2026 17:47
This comment has been minimized.
This comment has been minimized.
ValentinYoushkevich
force-pushed
the
refactor/ts-utils-index
branch
from
October 28, 2026 19:13
6547e18 to
403cf56
Compare
This comment has been minimized.
This comment has been minimized.
Type annotations come straight from the JSDoc types, and the imports of the module now use the `.ts` extension. Part of vuejs#2777
FloEdelmann
force-pushed
the
refactor/ts-utils-index
branch
from
October 29, 2026 14:42
403cf56 to
c649cee
Compare
FloEdelmann
approved these changes
Oct 30, 2026
FloEdelmann
left a comment
FloEdelmann
left a comment
Member
There was a problem hiding this comment.
Thanks once again for your continued effort in the TypeScript migration! This was a big chunk!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A draft that I'll fill in step by step; each commit can be reviewed on its own. The first commit moves
utils/indexwith annotations taken from the JSDoc types, imports it with the.tsextension (Node can't map the old.jspaths natively) and renameswithinTypeNodetoisWithinTypeNode.LinterandbuiltinRulesare imported at the top, sincerequireis missing when Node loads the file as ESM. Later commits drop the JSDoc tags section by section, migrate the built-in element lists and remove the Vitest alias foreslint-utils.scope.jsandts-utilsstay JavaScript, since JS files stillrequirethem.Part of #2777