Repository navigation
feat: Object.assign detection to mutation rules - #2929
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c943abf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the vue/no-mutating-props and vue/no-side-effects-in-computed-properties rules to detect mutations caused by Object.assign() when the target object (first argument) is a prop or reactive data.
Key changes:
- Added utility function to detect
Object.assigncalls with specific target nodes - Enhanced mutation detection logic to identify
Object.assignas a mutation operation - Added comprehensive test coverage for both valid and invalid
Object.assignusage patterns
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/utils/index.js | Added isObjectAssignCall utility function and integrated Object.assign detection into mutation analysis |
| tests/lib/rules/no-mutating-props.js | Added test cases for Object.assign prop mutation detection |
| tests/lib/rules/no-side-effects-in-computed-properties.js | Added test cases for Object.assign side effect detection in computed properties |
| .changeset/hot-beers-help.md | Added changelog entry documenting the enhancement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #2823