Skip to content

refactor: use regexp-groups to simplify ignores (POC) #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ST-DDT
Copy link
Contributor

@ST-DDT ST-DDT commented Jul 1, 2025

Implement idea suggested here: #2773 (comment)


Excluding/Ignoring things is a common task in rules. This PR creates a helper that hides all the string[] -> regexp[] -> boolean logic in a simple helper function.

const options = context.options[0] || {}
const { ignore = [] } = options
const ignoreGroupMatcher = regexp.toRegExpGroupMatcher(ignore)

...

 if (
  ignoreGroupMatcher(
    componentName,
    casing.pascalCase(componentName),
    casing.kebabCase(componentName)
  )
) {
  // skip
  return
}

The current project contains at least 9 instances of .map(toRegExp) + a few more using more verbose syntax.

If the general design of this feature is accepted, I will convert the other locations to the new feature and mark this PR as POC.

I'm not super happy with the method name and jsdocs, so any input would be appreciated.

Copy link

changeset-bot bot commented Jul 1, 2025

⚠️ No Changeset found

Latest commit: cb9a52f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea! I would be great to see it used a lot more in the whole codebase 🙂

@ST-DDT
Copy link
Contributor Author

ST-DDT commented Jul 2, 2025

I like the idea! I would be great to see it used a lot more in the whole codebase 🙂

Does that count as

the general design of this feature is accepted

so that I should start converting the rest of the applicable locations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants