refactor: store the defineEmits variable name #2592
Merged
+26
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
reviewed
Nov 4, 2024
|
yes, can check out here no-unused-emit-declarations L105 + require-explicit-emits L474 |
|
I'm confused. It sounds like there are behavior changes the rules? But none of the existing tests fail, so the behavior changes should be covered by new tests. |
Sry, I mean NO 🤖, this does not add support for any additional cases. |
FloEdelmann
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2585
Refactored to store the
defineEmitsvariable name for checkingdefineEmitsvariable name usage in the template.