fix(require-explicit-slots): ignore attribute binding - #2591
Merged
Conversation
FloEdelmann
reviewed
Nov 4, 2024
FloEdelmann
approved these changes
Nov 6, 2024
FloEdelmann
left a comment
FloEdelmann
left a comment
Member
There was a problem hiding this comment.
Looks good to me, I only have one more minor comment.
ota-meshi
approved these changes
Nov 11, 2024
ota-meshi
left a comment
ota-meshi
left a comment
Member
There was a problem hiding this comment.
LGTM! Thank you very much for your contributions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2589.
Previously: When
node.directivewas true,slotNamewas incorrectly set to 'default', and it would check if it was explicitly defined.Now: If
node.directiveis true and is not string literal, the report is simply skipped.