Fix Linter type import in index.d.ts #2572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for adding TypeScript declarations in the latest v9.29.0.
I found an issue when using the new declaration. In the
lib/index.d.ts
, theLinter
namespace is pointing totypings/eslint/index.d.ts
. However,typings/
is not included in the final NPM package, therefore the declarations inindex.d.ts
is not working.This issue can be fixed by adding a single line
import type { Linter } from 'eslint'
as shown in this PR.Other code-styling changes included in this PR are made by Prettier based on
eslint-plugin-vue
's Prettier config.Just FYI, the latest eslint has already includes TypeScript declarations, which means you don't need
@types/eslint
and perhaps alsotypings/eslint/index.d.ts
anymore onceeslint-plugin-vue
updated to the latest version of eslint (currentlyeslint-plugin-vue
is still using eslint@8).