Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs for v-model update:* event #2839

Merged

Conversation

xiaodong2008
Copy link
Contributor

Added #2810

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 33e1132
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/662f1f92e3a4510008bdfc39
😎 Deploy Preview https://deploy-preview-2839--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd
Copy link
Member

brc-dd commented Apr 29, 2024

Ah, wait this is documented, but it's currently only inside options API block (see later in the document). It should be shown on both composition and options API. It should be similar to what it was earlier - https://github.com/vuejs/docs/blob/7f299d98443efc489115d5f6b64d02094660dbd0/src/guide/components/v-model.md?plain=1 .

@xiaodong2008
Copy link
Contributor Author

Ah, wait this is documented, but it's currently only inside options API block (see later in the document). It should be shown on both composition and options API. It should be similar to what it was earlier - https://github.com/vuejs/docs/blob/7f299d98443efc489115d5f6b64d02094660dbd0/src/guide/components/v-model.md?plain=1 .

Okay, I will update this.

@xiaodong2008
Copy link
Contributor Author

Wait, but composition API already have an under the hood part(not complete), and it's not similar to options API, I just completed the part of the parent component, so I think this change is acceptable

https://vuejs.org/guide/components/v-model#under-the-hood

@NataliaTepluhina NataliaTepluhina merged commit 288f7bf into vuejs:main May 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants