Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(playground): compatible with esm-only unocss #322

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

LoTwT
Copy link
Contributor

@LoTwT LoTwT commented Apr 8, 2024

description

This PR is to close #321.

After checking, only some repositories under package/playground don't set type: "module". Sub packages such as applet, client, overlay, etc. have worked well with ESM.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 4563a5e
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/6614e13bc6da2900084a4336

@webfansplz webfansplz changed the title fix: be compatible with the esm-only unocss chore(playground): compatible with esm-only unocss Apr 9, 2024
@LoTwT
Copy link
Contributor Author

LoTwT commented Apr 9, 2024

I have removed the verbose Unocss dependencies.
I think dependencies need to be listed explicitly, even if it can work with the setting of shamefully-hoist=true in the .npmrc.

@webfansplz
Copy link
Member

I have removed the verbose Unocss dependencies. I think dependencies need to be listed explicitly, even if it can work with the setting of shamefully-hoist=true in the .npmrc.

Agree, Let's add it back 😅

@webfansplz webfansplz merged commit 4372aaa into vuejs:main Apr 9, 2024
8 checks passed
@LoTwT LoTwT deleted the uno branch April 9, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be compatible with the esm-only unocss.
2 participants