Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-ssr): handle ssr attr fallthrough when preserve whitespace #12304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/compiler-ssr/__tests__/ssrFallthroughAttrs.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,31 @@ describe('ssr: attrs fallthrough', () => {
`)
})

//#8072
test(`fallthrough component content (with whitespace: 'preserve')`, () => {
expect(
compile(
`
<a v-if="to">Foo</a>
<a v-else>Bar</a>
`,
{
whitespace: 'preserve',
},
).code,
).toMatchInlineSnapshot(`
"const { ssrRenderAttrs: _ssrRenderAttrs } = require("vue/server-renderer")

return function ssrRender(_ctx, _push, _parent, _attrs) {
if (_ctx.to) {
_push(\`<a\${_ssrRenderAttrs(_attrs)}>Foo</a>\`)
} else {
_push(\`<a\${_ssrRenderAttrs(_attrs)}>Bar</a>\`)
}
}"
`)
})

test('should not inject to fallthrough component content if not root', () => {
expect(compile(`<div/><transition><div/></transition>`).code)
.toMatchInlineSnapshot(`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ import {
} from '@vue/compiler-dom'

const filterChild = (node: ParentNode) =>
node.children.filter(n => n.type !== NodeTypes.COMMENT)
node.children.filter(
n => n.type !== NodeTypes.COMMENT && n.type !== NodeTypes.TEXT,
)

const hasSingleChild = (node: ParentNode): boolean =>
filterChild(node).length === 1
Expand Down