Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): properly rewrite :is with non-pseudo selector #12244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #12241

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 23, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12244

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12244

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12244

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12244

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12244

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12244

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12244

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12244

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12244

vue

pnpm add https://pkg.pr.new/vue@12244

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12244

commit: afbda36

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: sfc labels Oct 23, 2024
@zhangmo8
Copy link

This will cause pattern pollution and scoped will not work

image

image

@zhangmo8
Copy link

zhangmo8 commented Oct 24, 2024

Maybe it's another bug that I reproduced on the current official playground

I created a new issue to track it #12252

@edison1105
Copy link
Member Author

@zhangmo8

According to the document, I believe the behavior with this PR is proper.

@zhangmo8
Copy link

This pr is correct, you are so cool @edison1105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: sfc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sfc] css in scoped pseudo-element is not handled
2 participants