Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): fix The withDefaults function loses arguments when assigning a function default value #12243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hcg1023
Copy link
Contributor

@hcg1023 hcg1023 commented Oct 23, 2024

close #5253

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 23, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12243

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12243

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12243

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12243

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12243

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12243

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12243

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12243

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12243

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12243

vue

pnpm add https://pkg.pr.new/vue@12243

commit: 70d4af0

@edison1105 edison1105 changed the title fix(compiler-sfc): fix The withDefaults function loses arguments when… fix(compiler-sfc): fix The withDefaults function loses arguments when assigning a function default value Oct 23, 2024
@edison1105 edison1105 added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: script-setup ready for review This PR requires more reviews labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews scope: script-setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The withDefaults function loses arguments when assigning a function default value
2 participants