feat: syntax compatibility #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I think we still need to support the versions below v3.5.x. So |
|
... and it would be appreciated if you can further provide a reproduction with that warning. |
|
I initially discovered it from vuejs/test-utils#2548, and its Vue version has already reached 3.5+. |
|
I did not use TS declarations to specify the default value of the prop; I used the basic default in Prop Validation. It seems to solve this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4
Description
Vue 3.5+ supports Reactive Props Destructure.
Given that the
TranslationStatuscomponent is sourced directly and needs to be compatible with multiple Vue 3 versions, this PR ensures compatibility with bothVue 3.0+andVue 3.5+.