Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Disable CodeClimate Golang linters #53

Closed
wants to merge 1 commit into from
Closed

Conversation

bastjan
Copy link

@bastjan bastjan commented Sep 30, 2022

CodeClimate Go support is dead and still can't handle generics.

https://codeclimate.com/github/appuio/appuio-cloud-reporting/pull/88

image

codeclimate/codeclimate#1063

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@ccremer
Copy link
Contributor

ccremer commented Sep 30, 2022

Yeah, codeclimate is a pain lately...
Well if we start disabling all Go support for CodeClimate, what's the point of having it then?
Should we switch to different linter? I was thinking towards golang-ci, but it doesn't seem to have a coverage plugin. although tbh, I care less about coverage than bad smells in code.

@bastjan
Copy link
Author

bastjan commented Sep 30, 2022

golangci-lint is very good from experience. Coverage from CC is still supported even without the linters.

@ccremer
Copy link
Contributor

ccremer commented Sep 30, 2022

Ok, then I vote for switching. I ignore code coverage in our current projects anyway, so I don't see a reason to keep CC.
Would you be willing to add or extend this PR? If not, maybe I find some time

@ccremer ccremer mentioned this pull request Oct 21, 2022
3 tasks
@ccremer
Copy link
Contributor

ccremer commented Oct 24, 2022

Closing in favor of #57

@ccremer ccremer closed this Oct 24, 2022
@ccremer ccremer deleted the disable-cc-golang branch October 24, 2022 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants