-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for native docker networking #188
base: master
Are you sure you want to change the base?
Conversation
Thanks! I need to test this. I won't have time in the coming weeks due to travel but rest assured it's not ignored! :) |
sure, let me know if you need help setting things up. I've just tested it with a mix of 40 VMX and CSR VM-pods and it seems to be working fine. I'll write up a blogpost about this in the meantime, to close the loop and document everything before i forget. |
Any update on merging this patch? |
I want to share an update as it might be helpful. |
This would be great to merge, any chance that this mechanism could also be applied to the management network as an option? |
I second this PR as well. Could any contributor take a look into it for a formal approval? |
ive been playing around with this patch and have run in to an interesting problem. when attaching networks to containers, it does not seem to present them to the container in the order in which they were added. it seems to be doing an alphabetical sort or something. has anyone else seen this and/or know how to "fix" it. I've tried using docker-compose and network priorities but that doesnt seem to work either. |
@bdreisbach I think you may be hitting this? https://networkop.co.uk/post/2018-03-03-docker-multinet/ |
what do you mean plumb them in manually exactly? apparently not this?
i'd expect 192.168.144 to be on eth2. |
No, your example above is done using docker API. |
thanks for the pointer. it actually seems to "work" as i expect if i start the containers first, and then add the networks. |
another vote for getting this merged in with more recent vrnetlab commits 👍 |
@rnwolfe you may want to check out containerlab that builds on top of that idea |
@hellt thanks for pointing that out - seems very powerful. Just finished reading through your twitter announcement thread. This could be a good route for me to pursue using, but curious about extending it into k8s? |
Hey Kristian,
I've got your images working with native docker networking (main goal being to run it inside k8s). As I've said it only took a few minor changes to
vrnetlab.py
+ small changes to individuallaunch.py
to pass the flag at runtime. I've tried attaching VMs via macvtap but it doesn't seem to work from inside the container so I've resorted to plain-oldeth-bridge-tap
(which means that spanning-tree won't work).Have a look, tell me what you think. I'm getting back to work now so I didn't have time to run large-scale tests yet. So far I've tested it with a simple script connecting CSR/XRV and vMX back-to-back (example for vmx):