Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(previews): Add checkout ref for previews #88

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

afoley587
Copy link
Member

Rationale

Steve had an issue on #87 where he couldn't see his changes in PR previews.
This PR adds the proper checkout references so that git checkouts happen from the pr branch, not main.

Changes

Adds ${{ inputs.src-ref }} as an input to composite actions. Built from refs/pull/${{ inputs.pr-number }}/head.
Small refactor to alpha-sort inputs.

Testing

Tested in private repository.

@afoley587 afoley587 requested a review from a team as a code owner March 31, 2025 12:22
Copy link
Member

@findtopher findtopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit!

@afoley587 afoley587 merged commit 036c96b into main Mar 31, 2025
1 check passed
@afoley587 afoley587 deleted the afoley/pr-preview-checkouts branch March 31, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants