build(actions): Use separate preview domain #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findtopher
reviewed
Mar 26, 2025
findtopher
previously approved these changes
Mar 26, 2025
kevin-dimichel
previously approved these changes
Mar 26, 2025
|
The preview for this PR has been removed |
thesteve0
approved these changes
Mar 27, 2025
findtopher
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We should keep our previews completely separate from our (possibly) production site. Because of this, we should have different inputs which dictate where to publish a build to.
This does not parameterize
_clean_deploymentbecause we should never clean our production site(s).I also changed the names of the workflows to include
Compositeso, in the UI, we know which is which.