Embeddings legend mouse event fix

[ritch]

Fixes an issue with the embeddings legend where mouse events are handled by the Selector div which overlaps the legend.

Before

emb_legend_bug2.mov

After

fix_emb_legend2.mov

Summary by CodeRabbit

• Style
  • Improved pointer event handling in user interface components so that interactive elements (child components) now respond correctly to user interactions while their enclosing container remains non-interactive. This update enhances overall responsiveness and ensures a more intuitive experience when navigating and interacting with the UI.

[coderabbitai]

Walkthrough

This change adjusts the CSS pointer-events handling in the Selectors styled component. The component now ignores pointer events on the parent level by using pointer-events: none, while its child <div> elements capture all pointer events with pointer-events: all. No public entities have been modified.

Changes

File	Changes Summary
app/.../styled-components.tsx	Modified the Selectors styled component: set pointer-events: none on the parent and pointer-events: all on the child > div elements, altering how mouse events are captured and handled.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant P as Selectors (Parent)
    participant C as Child (div)
    U->>P: Pointer event occurs
    P-->>C: Event passes through (pointer-events: none)
    C->>U: Child handles the event (pointer-events: all)

Loading

Suggested reviewers

• imanjra

Poem

In the realm of code where pointers play,
I, the rabbit, hop along the way.
Parent is silent, child takes the lead,
In a dance of events, a nimble deed.
With a skip and a jump in the CSS art,
I cheer the changes from my furry heart!
🐇

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3fe2442 and d0ff46b.

📒 Files selected for processing (1)

• app/packages/embeddings/src/styled-components.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

**/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

• app/packages/embeddings/src/styled-components.tsx

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: test / test-python (ubuntu-latest-m, 3.12)
• GitHub Check: test / test-python (ubuntu-latest-m, 3.11)
• GitHub Check: test / test-python (ubuntu-latest-m, 3.10)
• GitHub Check: test / test-python (ubuntu-latest-m, 3.9)
• GitHub Check: test / test-app
• GitHub Check: build / build
• GitHub Check: e2e / test-e2e
• GitHub Check: lint / eslint

🔇 Additional comments (2)

app/packages/embeddings/src/styled-components.tsx (2)

22-22: Properly enables pointer events on child elements.

This addition of pointer-events: all ensures that the child div elements can still capture mouse events while the parent container ignores them. This is a good approach to solve the issue with the Selector div overlapping the legend.

---

26-26: Correctly disables pointer events on container.

Setting pointer-events: none on the parent container makes it transparent to mouse events, allowing clicks to "pass through" to elements underneath. Combined with the pointer-events: all on children, this creates a selective event handling pattern that fixes the issue described in the PR where the Selector div was interfering with legend interactions.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[imanjra]

LGTM