[Benchmark] Evaluate detections with map_samples #5596

minhtuev · 2025-03-18T07:09:25Z

What changes are proposed in this pull request?

(Please fill in changes proposed in this fix)

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

No. You can skip the rest of this section.
Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

App: FiftyOne application changes
Build: Build and test infrastructure changes
Core: Core fiftyone Python library changes
Documentation: FiftyOne documentation changes
Other

coderabbitai · 2025-03-18T07:09:31Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

fiftyone/core/map/process.py

j053y · 2025-03-19T11:55:15Z

fiftyone/core/map/process.py

@@ -260,7 +264,26 @@ def _map_batch(args: Tuple[int, int, fomb.SampleBatch]):
                if process_sample_count is not None:
                    with process_sample_count.get_lock():
                        process_sample_count.value += 1
+    except Exception as err:


We don't want the same logic for any exception, only map function errors.

If you're seeing other errors raised not related to the map function that means our code is erroring and not the user's input for that sample. So we should just fix it instead of forwarding it along.

j053y · 2025-03-19T11:55:48Z

fiftyone/core/map/process.py

@@ -136,8 +136,11 @@ def _map_sample_batches(
                    if batch_count.value >= num_batches:
                        break
                else:
+                    # Update progress bar
+                    pb.update()


fiftyone/utils/eval/detection.py

fiftyone/utils/map.py

j053y · 2025-03-19T12:05:43Z

fiftyone/utils/map.py

@@ -56,10 +63,12 @@ def update_samples(
    sample_collection,


Same as above method, either remove the types or make them correct and simplified.

minhtuev · 2025-03-19T17:13:00Z

@j053y : we won't be merging this PR since it's a working benchmarking script :) but I will cherry-pick the bug fix and create a new PR for map_samples

Added benchmark for evaluate detections

881b634

minhtuev added 3 commits March 18, 2025 00:26

Added backend option to benchmarking script

b32f6fa

Fixed progress bar

c9466d9

Added additional error handling

a49dffe

j053y requested changes Mar 19, 2025

View reviewed changes

minhtuev added 10 commits March 19, 2025 23:59

Merge branch 'project/map-samples' into benchmark/map-samples

7aa9062

Fixed progress bar

79648d6

Merge branch 'project/map-samples' into benchmark/map-samples

9804480

Updated with exponential backoff

318dbae

Added map_samples implementation for segmentation

f1773b7

Used map_samples for get_mask_values too

b8886ff

Merge branch 'project/map-samples' into benchmark/map-samples

ea0f7da

Added script to evaluate segmentation

bb1b936

updated script

f249550

Fixed progress bars

874c5ea

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Benchmark] Evaluate detections with map_samples #5596

[Benchmark] Evaluate detections with map_samples #5596

minhtuev commented Mar 18, 2025

coderabbitai bot commented Mar 18, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

j053y Mar 19, 2025

j053y Mar 19, 2025

j053y Mar 19, 2025

minhtuev commented Mar 19, 2025 •

edited

Loading

[Benchmark] Evaluate detections with map_samples #5596

Are you sure you want to change the base?

[Benchmark] Evaluate detections with map_samples #5596

Conversation

minhtuev commented Mar 18, 2025

What changes are proposed in this pull request?

How is this patch tested? If it is not, please explain why.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

What areas of FiftyOne does this PR affect?

coderabbitai bot commented Mar 18, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

j053y Mar 19, 2025

Choose a reason for hiding this comment

j053y Mar 19, 2025

Choose a reason for hiding this comment

j053y Mar 19, 2025

Choose a reason for hiding this comment

minhtuev commented Mar 19, 2025 • edited Loading

coderabbitai bot commented Mar 18, 2025 •

edited

Loading

minhtuev commented Mar 19, 2025 •

edited

Loading